feat: Add typescript support #595
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will reformat the title to use the proper commit message syntax. |
parse-github-assistant
bot
changed the title
|
🚀 Thanks for opening this pull request! |
- Modify package.json scripts and dependencies - Update index.ts for TypeScript compatibility
abubkr-hago
force-pushed
the
feat/typescript-support
branch
from
ddcd572 to
fc7e68a
Compare
abubkr-hago
force-pushed
the
feat/typescript-support
branch
2 times, most recently
from
0ff84ec to
4a1ae28
Compare
mtrezza
reviewed
Apr 21, 2025
mtrezza
reviewed
Apr 21, 2025
abubkr-hago
force-pushed
the
feat/typescript-support
branch
from
9524cf2 to
fd27b5b
Compare
mtrezza
reviewed
Apr 21, 2025
| const mountPath = process.env.PARSE_MOUNT || '/parse'; | ||
| const server = new ParseServer(config); | ||
|
|
||
| server.start().then(async () => { |
There was a problem hiding this comment.
Can we use top level await here?
There was a problem hiding this comment.
We have to convert the project to a module by adding type:module in package.json and incrementing the module and target in tsconfig making it not the same as Parse and Parse Server configs.
Should I change it in the tsconfig?
There was a problem hiding this comment.
Well, it's not necessary, if you feel like doing it, then I'll wait with merging, otherwise let me know and we merge as is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #561